feat: Huggingface provider integration #321
Conversation
| self | ||
| } | ||
|
|
||
| pub fn sub_provider(mut self, provider: SubProvider) -> Self { |
There was a problem hiding this comment.
| pub fn sub_provider(mut self, provider: SubProvider) -> Self { | |
| pub fn sub_provider(mut self, provider: impl Into<SubProvider>) -> Self { |
This makes it convenient to pass custom strings, though you still have to create impl From<&str> since FromStr is different 😭.
| Custom(String), | ||
| } | ||
|
|
||
| impl FromStr for SubProvider { |
There was a problem hiding this comment.
btw, FromStr != From<&str> unfortuntely
| } | ||
|
|
||
| pub fn build(self) -> Client { | ||
| let route = match self.sub_provider.clone() { |
There was a problem hiding this comment.
I would implement ToString for SubProvider here so it's consistent with the enum, then you can use that directly
| // } | ||
| // _ => panic!("Expected user message"), | ||
| // } | ||
| } |
There was a problem hiding this comment.
Should this still be commented?
| // ================================================================ | ||
| const HUGGINGFACE_API_BASE_URL: &str = "https://router.huggingface.co/"; | ||
|
|
||
| #[derive(Debug, Clone, PartialEq)] |
There was a problem hiding this comment.
Derive Default and set it to be HFInference
| Self { | ||
| api_key: api_key.to_string(), | ||
| base_url: HUGGINGFACE_API_BASE_URL.to_string(), | ||
| sub_provider: SubProvider::HFInference, |
| let path = match self.client.sub_provider { | ||
| SubProvider::HFInference => format!("/{}/v1/chat/completions", self.model), | ||
| _ => "/v1/chat/completions".to_string(), | ||
| }; |
There was a problem hiding this comment.
Perhaps it be good to also add a method to generate this string on the enum as well
There was a problem hiding this comment.
Yeah good point, reduces the repetition between normal completion and streaming
| let path = match self.client.sub_provider { | ||
| SubProvider::HFInference => format!("/{}/v1/chat/completions", self.model), | ||
| _ => "/v1/chat/completions".to_string(), | ||
| }; |
There was a problem hiding this comment.
Ditto commment in completion
Adds support for Huggingface models.
Closes #36.